Bunch 'o DOCSIS Tests.

skyscraper8.Tests/CapturedTests.cs

@@ -0,0 +1,109 @@
+using System.IO;
+using Microsoft.VisualStudio.TestTools.UnitTesting;
+using skyscraper5.Mpeg2;
+using skyscraper5.Skyscraper.Scraper;
+using skyscraper5.Skyscraper.Scraper.Storage.InMemory;
+using skyscraper8.Skyscraper.Scraper.Storage;
+
+namespace skyscraper8.Tests;
+
+[TestClass]
+public class CapturedTests : Feyllure
+{
+    [TestMethod]
+    public void RussianT2Mi()
+    {
+        FileStream streamSample = GetStreamSample("express_3928L_t2mi.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //42931 uncovered
+    }
+
+    [TestMethod]
+    public void Simmin()
+    {
+        FileStream streamSample = GetStreamSample("thor_11049v_simmin-radiomidun.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //36611 uncovered
+    }
+
+    [TestMethod]
+    public void GseDab()
+    {
+        FileStream streamSample = GetStreamSample("thor_10717v_gse-dab.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //36446 uncovered
+    }
+
+    [TestMethod]
+    public void SouthAmericanNip()
+    {
+        FileStream streamSample = GetStreamSample("argentinian-dvb-nip-000000.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //35222
+    }
+
+    [TestMethod]
+    public void GseNip()
+    {
+        FileStream streamSample = GetStreamSample("astra1_12441v_gse-nip.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //34545
+    }
+
+    [TestMethod]
+    public void GseNip2()
+    {
+        FileStream streamSample = GetStreamSample("astra1_11141h_gse_nip.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //34462
+    }
+
+    [TestMethod]
+    public void TsNipIncludingLegacyChannel()
+    {
+        FileStream streamSample = GetStreamSample("hotbird_12380v_nip.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //33518
+    }
+
+    [TestMethod]
+    public void TsNip()
+    {
+        FileStream streamSample = GetStreamSample("hotbird_12226v_nip.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //33518
+    }
+
+    [TestMethod]
+    public void Rcs2Nip()
+    {
+        FileStream streamSample = GetStreamSample("telstar12v-bfbs-000000.ts");
+        ProcessSample(streamSample);
+        streamSample.Close();
+        //32559
+    }
+    
+    
+
+    private void ProcessSample(Stream sample)
+    {
+        TsContext ts = new TsContext();
+        
+        InMemoryScraperStorageFactory inMemoryStorageFactory = new InMemoryScraperStorageFactory();
+        DataStorage dataStorage = inMemoryStorageFactory.CreateDataStorage();
+        
+        NullObjectStorage nullObjectStorage = new NullObjectStorage();
+
+        SkyscraperContext context = new SkyscraperContext(ts, dataStorage, nullObjectStorage);
+        context.InitalizeFilterChain();
+        context.IngestFromStream(sample);
+    }
+}

skyscraper8.Tests/Feyllure.cs

@@ -1,6 +1,7 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
+using System.Reflection;
 using System.Runtime.InteropServices;
 using Allure.Net.Commons;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
@@ -94,6 +95,10 @@ public class Feyllure
             case UnitTestOutcome.Failed:
                 Allure.UpdateTestCase(tc => tc.status = Status.failed);
                 break;
+            case UnitTestOutcome.Inconclusive:
+                Allure.UpdateTestCase(tc => tc.status = Status.skipped);
+                Print("\n\n" + TestContext.TestException.ToString());
+                break;
             default:
                 StepResult stepResult = new StepResult();
                 stepResult.name = String.Format("Current Test Outcome: {0}", TestContext.CurrentTestOutcome);;
@@ -123,4 +128,66 @@ public class Feyllure
         Console.WriteLine(formattedMessage);
         descriptionWriter.WriteLine(formattedMessage);
     }
+
+    private DirectoryInfo testsuitePath;
+    protected DirectoryInfo GetTestsuitePath()
+    {
+        Print("Checking whether skyscraper-testsuite exists...");
+        if (Directory.Exists("skyscraper-testsuite"))
+        {
+            testsuitePath = new DirectoryInfo("skyscraper8-testsuite");
+            return testsuitePath;
+        }
+
+        Print("Checking TESTSUITE_PATH...");
+        string directory = Environment.GetEnvironmentVariable("TESTSUITE_PATH");
+        if (!string.IsNullOrEmpty(directory))
+        {
+            testsuitePath = new DirectoryInfo(directory);
+            return testsuitePath;
+        }
+
+        FileInfo pointerFile = new FileInfo("skyscraper8-testsuite-path.txt");
+        Print("Checking {0}...",pointerFile.FullName);
+        if (File.Exists(pointerFile.FullName))
+        {
+            string readAllText = File.ReadAllText(pointerFile.FullName);
+            readAllText = readAllText.Trim();
+            testsuitePath = new DirectoryInfo(readAllText);
+            return testsuitePath;
+        }
+        
+        Assert.Inconclusive("Could not find the test suite path.");
+        return null;
+    }
+
+    protected FileStream GetStreamSample(string streamName)
+    {
+        DirectoryInfo testsuitePath = GetTestsuitePath();
+        string combine = Path.Combine(testsuitePath.FullName, streamName);
+        FileInfo result = new FileInfo(combine);
+        if (!result.Exists)
+        {
+            Assert.Inconclusive(String.Format("Could not find {0}",result.FullName));
+            return null;
+        }
+        
+        return result.OpenRead();
+    }
+
+    protected void AssertTargetInvocation<T>(Action action)
+        where T: Exception
+    {
+        Assert.Throws<T>(() =>
+        {
+            try
+            {
+                action();
+            }
+            catch (TargetInvocationException tie)
+            {
+                throw tie.InnerException;
+            }
+        });
+    }
 }

skyscraper8.Tests/RootTests/DocsisTests.cs

@@ -1,9 +1,12 @@
 using System;
+using System.Collections.Generic;
 using System.IO;
 using System.Net.NetworkInformation;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using skyscraper5.Docsis;
 using skyscraper5.Docsis.AnnexC;
+using skyscraper5.Docsis.MacManagement;
+using skyscraper5.Docsis.MacManagement.BaselinePrivacyKeyManagementMessages;
 
 namespace skyscraper8.Tests.RootTests;
 
@@ -597,4 +600,616 @@ public class DocsisTests : Feyllure
         UntestableMacManagementMessage ummm = new UntestableMacManagementMessage(srcAddr, dstAddr, dataBuffer);
         Assert.IsNull(ummm.MessageType);
     }
+
+    [TestMethod]
+    public void UpstreamChannelDescriptorTests()
+    {
+        byte[] buffer = new byte[]
+        {
+            1,1,1,1,        //header
+            1,1,1,          //modulation rate
+            2,4,0,0,0,1,    //frequency
+            3,1,1,          //preamble pattern
+            5,1,1,          //Burst descriptor
+            6,1,1,
+            7,1,1,
+            15,0,
+            16,1,3,
+            23,1,2,
+            24,2,0,2,
+            25,5,0,0,0,0,2,
+            26,1,2,
+            27,1,2,
+            28,1,2,
+            29,4,0,0,0,2,
+            30,4,0,3,0,3,
+            32,1,3,
+            33,3,0,0,3
+        };
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        byte[] dstBuffer = new byte[6];
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+        UpstreamChannelDescriptor ucd = new UpstreamChannelDescriptor(srcAddr, dstAddr, buffer);
+        Assert.AreEqual((byte)1, ucd.ModulationRate);
+        Assert.AreEqual(1u, ucd.Frequency.Value);
+        Assert.AreEqual((byte)1, ucd.PreamblePattern[0]);
+        Assert.IsNotEmpty(ucd.BurstDescriptors);
+        Assert.AreEqual((byte)1, ucd.ExtendedPreamblePattern[0]);
+        Assert.IsTrue(ucd.S_CDMAMode.Value);
+        Assert.AreEqual(UpstreamChannelDescriptor.RangingRequiredEnum.ProbingRequired, ucd.RangingRequired);
+        Assert.IsNotNull(ucd.UcdChangeIndicator);
+        Assert.AreNotEqual(2,ucd.OfdmaTimestampSnapshot.Value);
+        Assert.AreEqual(2, ucd.OfdmaTimestampSnapshotDivideBy20.Value);
+        Assert.AreEqual((byte)2, ucd.OfdmaCyclicPrefixSize);
+        Assert.AreEqual((byte)2, ucd.OfdmaRolloffPeriodSize);
+        Assert.AreEqual((byte)2, ucd.SubcarrierSpacing);
+        Assert.AreEqual((uint)2, ucd.CenterFrequencyOfSubcarrier0);
+        Assert.AreEqual((ushort)3, ucd.SubcarrierExclusionBand[0].Item2);
+        Assert.AreEqual(3, ucd.SymbolsInOfdmaFrame.Value);
+        Assert.AreEqual(3u, ucd.RandomizationSeed);
+
+        buffer = new byte[]
+        {
+            0, 0, 0, 0,
+            31,1,1
+        };
+        Assert.Throws<NotImplementedException>(() => new UpstreamChannelDescriptor(srcAddr, dstAddr, buffer));
+
+        buffer = new byte[]
+        {
+            3, 3, 42, 101,
+            7, 1, 3
+        };
+        ucd = new UpstreamChannelDescriptor(srcAddr, dstAddr, buffer);
+        Assert.IsNull(ucd.S_CDMAMode);
+        Assert.AreEqual(101,ucd.DownstreamChannelId);
+        Assert.AreEqual(42, ucd.MinislotSize);
+        Assert.AreEqual(3, ucd.ConfigurationChangeCount);
+        Assert.AreEqual(3, ucd.UpstreamChannelID);
+    }
+
+    [TestMethod]
+    public void BurstDescriptorTests()
+    {
+        byte[] buffer = new byte[]
+        {
+            1,
+            1,1,1,
+            2,1,1,
+            3,2,0,1,
+            4,2,0,1,
+            5,1,1,
+            6,1,1,
+            7,2,0,1,
+            8,1,1,
+            9,1,1,
+            10,1,2,
+            11,1,1,
+            12,1,1,
+            13,2,0,1,
+            14,1,2,
+            19,2,0,1,
+            20,2,0,2,
+            21,2,0x8f,255,
+            22,2,10,4
+        };
+        UpstreamChannelDescriptor.BurstDescriptor bd = new UpstreamChannelDescriptor.BurstDescriptor(buffer);
+        Assert.AreEqual(1, bd.ModulationType.Value);
+        Assert.IsTrue(bd.DifferentialEncoding.Value);
+        Assert.AreEqual(1, bd.PreambleLength.Value);
+        Assert.AreEqual(1, bd.PreambleValueOffset.Value);
+        Assert.AreEqual(1, bd.FecErrorCorrection.Value);
+        Assert.AreEqual(1, bd.FecCodewordInformationBytes.Value);
+        Assert.AreEqual(1, bd.ScramblerSeed.Value);
+        Assert.AreEqual(1, bd.MaximumBurstSize.Value);
+        Assert.AreEqual(1, bd.GuardTimeSize.Value);
+        Assert.AreEqual(UpstreamChannelDescriptor.BurstDescriptor.CodewordLength.Shortened,bd.LastCodewordLength.Value);
+        Assert.IsTrue(bd.Scrambler.Value);
+        Assert.AreEqual(1, bd.RsInterleaverDepth.Value);
+        Assert.AreEqual(1, bd.RsInterleaverBlockSize.Value);
+        Assert.AreEqual(1, bd.SubcarriersInitialRanging.Value);
+        Assert.AreEqual(2, bd.SubcarriersFineRanging.Value);
+        Assert.IsNotEmpty(bd.OfdmaDataProfiles);
+        Assert.AreEqual(255, bd.OfdmaDataProfiles[0].NumberOfMinisolts);
+        Assert.AreEqual(0x0f, bd.OfdmaDataProfiles[0].PilotPatternIndex);
+        Assert.AreEqual(UpstreamChannelDescriptor.OfdmaDataProfile.ModulationOrderIndex._256QAM, bd.OfdmaDataProfiles[0].Modulation);
+        Assert.AreEqual(16.0,bd.OfdmaBroadcastIrStartingPowerLevel.Value);
+        Assert.AreEqual(1.0, bd.OfdmaBroadcastIrStartingPowerLevelIncrease.Value);
+        Assert.AreEqual(UpstreamChannelDescriptor.BurstDescriptor.PreambleTypeEnum.QPSK1,bd.PreambleType.Value);
+        Assert.AreEqual(1, bd.IntervalUsageCode);
+        //TO BE CONTINUED...
+
+        buffer = new byte[]
+        {
+            2,
+            2, 1, 2,
+            11,1, 2,
+        };
+        bd = new UpstreamChannelDescriptor.BurstDescriptor(buffer);
+        Assert.IsFalse(bd.DifferentialEncoding.Value);
+        Assert.IsFalse(bd.Scrambler.Value);
+        
+        buffer = new byte[]
+        {
+            3,
+            2, 1, 3,
+            11,1, 3,
+        };
+        bd = new UpstreamChannelDescriptor.BurstDescriptor(buffer);
+        Assert.IsNull(bd.DifferentialEncoding);
+        Assert.IsNull(bd.Scrambler);
+
+        buffer = new byte[]
+        {
+            4,
+            42, 1, 0
+        };
+        Assert.Throws<NotImplementedException>(() => new UpstreamChannelDescriptor.BurstDescriptor(buffer));
+    }
+
+    [TestMethod]
+    public void UcdChangeIndicatorBitmaskTest()
+    {
+        UpstreamChannelDescriptor.UcdChangeIndicatorBitmask ucdcib =
+            new UpstreamChannelDescriptor.UcdChangeIndicatorBitmask(0xffff);
+        Assert.IsTrue(ucdcib.ChangeIuc14);
+        Assert.IsTrue(ucdcib.ChangeIuc13);
+        Assert.IsTrue(ucdcib.ChangeIuc12);
+        Assert.IsTrue(ucdcib.ChangeIuc11);
+        Assert.IsTrue(ucdcib.ChangeIuc10);
+        Assert.IsTrue(ucdcib.ChangeIuc9);
+        Assert.IsTrue(ucdcib.ChangeIuc6);
+        Assert.IsTrue(ucdcib.ChangeIuc5);
+        Assert.IsTrue(ucdcib.ChangeOtherParameters);
+        Assert.IsTrue(ucdcib.ChangeUnusedSubcarrierSpecification);
+        Assert.IsTrue(ucdcib.ChangeSubcarrierExclusionBand);
+        Assert.AreEqual(0xffff,ucdcib.GetRawValue());
+    }
+
+    [TestMethod]
+    public void MultipartRegistrationResponse()
+    {
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        byte[] dstBuffer = new byte[6];
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+
+        byte[] payload = new byte[]
+        {
+            0,1,    //SID
+            1,      //Response
+            1,      //Number of Fragments
+            1,      //Fragment Sequence Number
+            0,      //TLV encoded information
+        };
+
+        T45_V4_MultipartRegistrationResponse mrr = new T45_V4_MultipartRegistrationResponse(srcAddr, dstAddr, payload);
+        Assert.AreEqual(1, mrr.SID);
+        Assert.AreEqual(1, mrr.Response);
+        Assert.AreEqual(1, mrr.NumberOfFragments);
+        Assert.AreEqual(1, mrr.FragmentSequenceNumber);
+        Assert.IsNotNull(mrr.TlvEncodedInformation);
+    }
+
+    [TestMethod]
+    public void RangingResponseTest()
+    {
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        byte[] dstBuffer = new byte[6];
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+
+        byte[] payload = new byte[]
+        {
+            0,1,    //SID
+            1,      //Upstream Channel ID
+            1,4,0,0,0,1,
+            2,1,1,
+            3,2,0,1,
+            4,1,1,
+            5,1,3,
+            6,4,0,0,0,1,
+            7,1,1,
+            9,1,1,
+            11,1,1,
+            12,3,7,7,3,
+            13,1,1,
+            14,1,1,
+            15,0,   7,  1,1,1,0,1,0,1,
+            16,0,   7,  1,1,1,0,1,0,1,
+            17,6,    1,1,1, 2,1,1,
+            18,3,   2,1,1,
+            8,1,1,
+            10,1,1
+        };
+        RangingResponse rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.AreEqual(1, rr.SID.Value);
+        Assert.AreEqual(1, rr.UpstreamChannelId.Value);
+        Assert.AreEqual(1u, rr.TimingAdjust.Value);
+        Assert.AreEqual(1, rr.PowerLevelAdjust.Value);
+        Assert.AreEqual(1, rr.OffsetFrequencyAdjust.Value);
+        Assert.AreEqual(1, rr.TxEqualizationData[0]);
+        Assert.AreEqual(RangingResponse.RangingStatusEnum.Success, rr.RangingStatus);
+        Assert.AreEqual(1u, rr.DownstreamFrequencyOverride.Value);
+        Assert.AreEqual(1, rr.UpstreamChannelIdOverride.Value);
+        Assert.AreEqual(1, rr.T4TimeoutMultiplier.Value);
+        Assert.AreEqual(1.0, rr.TransmitEqualizationAdjustForOfdmaChannels.Coefficients[0].Imaginary);
+        Assert.AreEqual(1.0,rr.TransmitEqualizationSetForOfdmaChannels.Coefficients[0].Imaginary);
+        Assert.AreEqual(1, rr.TransmitEqualizationSet[0]);
+        Assert.AreEqual(0.25, rr.DynamicRangeWindowUpperEdge.Value);
+        Assert.IsTrue(rr.CommandPower.Valid);
+        Assert.AreEqual(1, rr.CommandPower.DynamicRangeWindow.Value);
+        Assert.AreEqual(1, rr.CommandPower.TransmitPowerLevels[0]);
+        Assert.AreEqual(1, rr.SCdmaPowerHeadroom.Value);
+        Assert.IsNotNull(rr.FdxCommandedPower);
+        Assert.AreEqual(1, rr.TimingAdjustFractionalPart.Value);
+        Assert.AreEqual(1, rr.SCdmaMaximumScheduledCodes.Value);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            3, 1, 0
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            1, 1, 0
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            12, 3, 7, 1, 1
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.UpstreamChannelAdjustments.Valid);
+        
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            12, 3, 5, 1, 1
+        };
+        Assert.Throws<NotImplementedException>(() => new RangingResponse(srcAddr, dstAddr, payload));
+        
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            12, 1,0
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsTrue(rr.UpstreamChannelAdjustments.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            3, 4, 0, 0
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            0, 1, 1,
+            3, 0,
+            4, 1, 1
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            6, 3, 0, 0, 0
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            17, 1, 1
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+        
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            18, 1, 1
+        };
+        rr = new RangingResponse(srcAddr, dstAddr, payload);
+        Assert.IsFalse(rr.Valid);
+        
+        payload = new byte[]
+        {
+            0, 1,
+            1,
+            42, 1, 1
+        };
+        Assert.Throws<NotImplementedException>(() => new RangingResponse(srcAddr, dstAddr, payload));
+        
+    }
+
+    [TestMethod]
+    public void CommandPowerObjectTest()
+    {
+        byte[] payload = new byte[]
+        {
+            0
+        };
+        
+        RangingResponse.CommandPowerObject commandPower = new RangingResponse.CommandPowerObject(payload);
+        Assert.IsFalse(commandPower.Valid);
+
+        payload = new byte[]
+        {
+            1, 4, 0, 0, 0
+        };
+        commandPower = new RangingResponse.CommandPowerObject(payload);
+        Assert.IsFalse(commandPower.Valid);
+
+        payload = new byte[]
+        {
+            3, 1, 1
+        };
+        commandPower = new RangingResponse.CommandPowerObject(payload);
+        Assert.IsFalse(commandPower.Valid);
+    }
+
+    [TestMethod]
+    public void PrivacyKeyManagementResponseTest()
+    {
+        NullDocsisEventHandler nullDocsisEventHandler = new NullDocsisEventHandler();
+        DocsisEnvironment docsisEnvironment = new DocsisEnvironment(nullDocsisEventHandler);
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        byte[] dstBuffer = new byte[6];
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+
+        byte[] payload = new byte[]
+        {
+            5,  //Code
+            1,  //Identifier
+            0, 4 + 7 + 4 + 3 + 5 + 5 + 5,  //Length (von der darauf folgenden Message)
+            
+            //Hier beginnt die Message (length sind immer zwei bytes)
+            7, 0, 1, 1,
+            9, 0, 4, 0, 0, 0, 1,
+            10, 0, 1, 1,
+            
+            23, 0, 5 + 5 + 5,   //length für den SA descriptor
+            
+            //Hier fängt der SA descriptor an
+            12, 0, 2, 0, 1,
+            20, 0, 2, 2, 0,
+            24, 0, 1, 0, 2,
+        };
+        docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload);
+        
+        //Falsche Länge der Message
+        payload = new byte[]
+        {
+            5,  //Code
+            1,  //Identifier
+            0, 2,  //Length (von der darauf folgenden Message)
+            
+            //Hier beginnt die Message
+            0,
+        };
+        docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload);
+        
+        //Unimplementierter message type
+        payload = new byte[]
+        {
+            42,  //Code
+            1,  //Identifier
+            0, 1,  //Length (von der darauf folgenden Message)
+            
+            //Hier beginnt die Message
+            0,
+        };
+        docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload);
+
+        //Auth Reply NotImplemented
+        payload = new byte[]
+        {
+            5,
+            1,
+            0, 4,
+
+            255, 0, 1, 1
+        };
+        AssertTargetInvocation<NotImplementedException>(() => docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload));
+        
+        //Privacy Key Management Response Unimplemented Message Type
+        payload = new byte[]
+        {
+            10,
+            1,
+            0, 3,
+
+            255, 255, 255
+        };
+        AssertTargetInvocation<NotImplementedException>(() => docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload));
+
+        //Sa Descriptor Unimplemented TLV
+        payload = new byte[]
+        {
+            5,
+            1,
+            0, 7, //Länge für darauffolgendes
+
+            23,
+            0, 4, //Länge für darauffolgendes
+            8, 0, 1, 1
+        };
+        AssertTargetInvocation<NotImplementedException>(() => docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload));
+            
+        payload = new byte[]
+        {
+            8,  //Code
+            1,  //Identifier
+            0, 4 + 7 + 5 + 1 + 2 + 4 + 7 + 4 + 4,   //Length für alles darauf folgende
+            
+            10, 0, 1, 1,
+            11, 0, 4, 0, 0, 0, 1,
+            12, 0, 2, 0, 1,
+            13,             //TEK parameters 
+            0, 4 + 7 + 4 + 4,           //Length für alles darauf folgende
+            8, 0, 1, 1,
+            9, 0, 4, 0, 0, 0, 1,
+            10, 0, 1, 1,
+            15, 0, 1, 1,
+        };
+        docsisEnvironment.PushMacManagementMessage(null, 1, 13, srcAddr, dstAddr, payload);
+
+        Queue<object> queue = nullDocsisEventHandler.GetQueue();
+        while (queue.Count > 0)
+        {
+            PrivacyKeyManagementResponse dequeue = queue.Dequeue() as PrivacyKeyManagementResponse;
+            Assert.AreEqual(1,dequeue.Identifier);
+            switch (dequeue.BpkmMessage)
+            {
+                case AuthReply ar:
+                    Assert.AreNotEqual(255,ar.KeySequenceNumber);
+                    Assert.AreNotEqual(255u,ar.KeyLifetime);
+                    if (ar.SaDescriptor != null)
+                    {
+                        Assert.AreNotEqual(255, ar.SaDescriptor.SAID);
+                        Assert.AreNotEqual(AuthReply.SaDescriptorObject.SaTypeEnum.Dynamic, ar.SaDescriptor.SaType);
+                        Assert.AreNotEqual(AuthReply.SaDescriptorObject.DataEncryptionAlgorithmIdentifiers.Cbc128Aes, ar.SaDescriptor.DataEncryptionAlgorithm);
+                        Assert.AreEqual(AuthReply.SaDescriptorObject.DataAuthenticationIdentifiers.NoDataAuthentication, ar.SaDescriptor.DataAuthenticationAlgorithm);
+                    }
+
+                    if (ar.AuthKey != null)
+                    {
+                        Assert.IsNotNull(ar.AuthKey);
+                    }
+                    break;
+                case KeyReply kr:
+                    Assert.AreNotEqual(255, kr.KeySequenceNumber.Value);
+                    Assert.IsNotNull(kr.HmacDigest);
+                    Assert.AreNotEqual(255, kr.SAID.Value);
+                    if (kr.TekParameters.Count > 0)
+                    {
+                        KeyReply.TekParameter krTekParameter = kr.TekParameters[0];
+                        Assert.IsNotNull(krTekParameter.KeyLifetime);
+                        Assert.IsNotNull(krTekParameter.CbcIv);
+                        Assert.IsNotNull(krTekParameter.TekKeySequenceNumber);
+                        Assert.IsNotNull(krTekParameter.TEK);
+                    }
+                    break;
+                case null:
+                    break;
+                default:
+                    throw new NotImplementedException(dequeue.BpkmMessage.ToString());
+            }
+        }
+    }
+
+    [TestMethod]
+    public void KeyReplyTest()
+    {
+        byte[] payload = new byte[]
+        {
+            254, 0, 1, 0
+        };
+        Assert.Throws<NotImplementedException>(() => new KeyReply(payload));
+    }
+
+    [TestMethod]
+    public void TekParameterTest()
+    {
+        byte[] payload = new byte[]
+        {
+            254, 0, 1, 0
+        };
+        Assert.Throws<NotImplementedException>(() => new KeyReply.TekParameter(payload));
+
+        payload = new byte[]
+        {
+            10, 0, 1, 1,
+            8, 0, 1, 2
+        };
+        KeyReply.TekParameter tekParameter = new KeyReply.TekParameter(payload);
+        Print(tekParameter.ToString());
+    }
+
+    [TestMethod]
+    public void DynamicServiceAdditionResponseTest()
+    {
+        NullDocsisEventHandler nullDocsisEventHandler = new NullDocsisEventHandler();
+        DocsisEnvironment docsisEnvironment = new DocsisEnvironment(nullDocsisEventHandler);
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        byte[] dstBuffer = new byte[6];
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+
+        byte[] payload = new byte[]
+        {
+            0, 1,   //Transaction ID
+            1,      //Confirmation Code
+        };
+        
+        docsisEnvironment.PushMacManagementMessage(null, 2, 16, srcAddr, dstAddr, payload);
+    }
+
+    [TestMethod]
+    public void NullDocsisEventHandlerTest()
+    {
+        NullDocsisEventHandler nullDocsisEventHandler = new NullDocsisEventHandler();
+        Random rng = new Random();
+        byte[] srcBuffer = new byte[6];
+        rng.NextBytes(srcBuffer);
+        PhysicalAddress srcAddr = new PhysicalAddress(srcBuffer);
+
+        nullDocsisEventHandler.OnParticipantDetected(srcAddr);
+        HashSet<PhysicalAddress> physicalAddresses = nullDocsisEventHandler.GetParticipants();
+        Assert.Contains(srcAddr, physicalAddresses);
+        
+        rng.NextBytes(srcBuffer);
+        srcAddr = new PhysicalAddress(srcBuffer);
+        nullDocsisEventHandler.OnCmtsTimestamp(srcAddr, 1);
+        Assert.Contains(srcAddr, physicalAddresses);
+        Assert.AreEqual(1u, nullDocsisEventHandler.GetTiming());
+
+        byte[] ucdPayload = new byte[]
+        {
+            1,
+            0,
+            0,
+            1
+        };
+        byte[] dstBuffer = new byte[6];
+        rng.NextBytes(dstBuffer);
+        PhysicalAddress dstAddr = new PhysicalAddress(dstBuffer);
+        UpstreamChannelDescriptor ucd = new UpstreamChannelDescriptor(srcAddr, dstAddr, ucdPayload);
+        nullDocsisEventHandler.OnUpstreamChannel(ucd);
+        object dequeue = nullDocsisEventHandler.GetQueue().Dequeue();
+        Assert.AreEqual(ucd, dequeue);
+        
+        
+    }
 }

skyscraper8.sln.DotSettings.user

@@ -4,19 +4,32 @@
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AArray_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F6e_003Fd247db11_003FArray_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AAssert_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F053cba69424c47858472194d509c3cdc12bb0_003F37_003F58cc70f4_003FAssert_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AAssert_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003Fa840692e98b74557bc005b38213a22c72dad0_003Fc8_003F58c2e0c9_003FAssert_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AAssert_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003F62bb4746d7d14dc1cd4274a28788572a7a4641bd3a7d5736479c9697bcb4794_003FAssert_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AAssert_002EInconclusive_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003F8e305e26401afcd395b5be2da0e23d61432655dc5f2c2e5e6d5bd873bb0cb90_003FAssert_002EInconclusive_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AAssert_002EThrowsException_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003Fe6930caf46f7fcaa445fdd26a3884170a45a4766298259e7a29bae560adef_003FAssert_002EThrowsException_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ACultureInfo_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F8e_003Fe58e5b4a_003FCultureInfo_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ADictionary_00602_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F83_003Fc73c45bc_003FDictionary_00602_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AFastResourceComparer_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F8f_003Ffb4ed86c_003FFastResourceComparer_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AFileInfo_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003Fe1ab690537c44e02a014076312b886b7b2e200_003F5a_003Fcf76af61_003FFileInfo_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AInterop_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fea_003F7d70064b_003FInterop_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AList_00601_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F6b_003Fa410ee2c_003FList_00601_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AMemberInfo_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fce_003F751a2c1f_003FMemberInfo_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AMemoryStream_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F0d_003F068af3a6_003FMemoryStream_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AMethodBaseInvoker_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F7a_003F86728bdc_003FMethodBaseInvoker_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ANotImplementedException_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fa3_003F2c4f9089_003FNotImplementedException_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ANullable_00601_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F0d_003F6549c49b_003FNullable_00601_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ANullAsserts_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003F3f4719f7ce375226774d6991a6afc2f6932e58b42fd58ff13c7c03771642e_003FNullAsserts_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AObject_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F55_003F6efc7017_003FObject_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AQueue_00601_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fb6_003F498e7c75_003FQueue_00601_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AReadOnlyDictionary_00602_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F0d_003F1270c638_003FReadOnlyDictionary_00602_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AResourceManager_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F0c_003Fb548fbc6_003FResourceManager_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ARuntimeInformation_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F4c_003F5f771d10_003FRuntimeInformation_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ARuntimeResourceSet_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fe1_003Ff15f6bbe_003FRuntimeResourceSet_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ASafeFileHandle_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Fc6_003Fd8e0f2f2_003FSafeFileHandle_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ASkip_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003Fd8c543d93f1559af2ea2be8e9d55839b5bb1a3605f22daa45ea63772e3b4bc_003FSkip_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ASR_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F4d_003F7edc51d9_003FSR_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AString_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003F2e_003F1a14f40f_003FString_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003ATestMethodInfo_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FSourcesCache_003F9ea467e7c7b4671a214143293021e7ec337916b71125d896e17a0b7fc_003FTestMethodInfo_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AThrowHelper_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003F57d616db882b441b8c50720b4477e03db2e200_003Feb_003F3c476997_003FThrowHelper_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AThrowHelper_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003Fe1ab690537c44e02a014076312b886b7b2e200_003F4f_003F7bfc5050_003FThrowHelper_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=7020124F_002D9FFC_002D4AC3_002D8F3D_002DAAB8E0240759_002Ff_003AThrowHelper_002Ecs_002Fl_003A_002E_002E_003F_002E_002E_003F_002Econfig_003FJetBrains_003FRider2025_002E1_003Fresharper_002Dhost_003FDecompilerCache_003Fdecompiler_003Ffb63d7b4f026464dbf9b2db60c7f76bc2ac00_003Fbd_003F4080deac_003FThrowHelper_002Ecs/@EntryIndexedValue">ForceIncluded</s:String>
@@ -26,12 +39,22 @@
   &lt;Assembly Path="/home/schiemas/.nuget/packages/allure.net.commons/2.14.1/lib/netstandard2.0/Allure.Net.Commons.dll" /&gt;
 &lt;/AssemblyExplorer&gt;</s:String>
 	<s:String x:Key="/Default/Environment/Highlighting/HighlightingSourceSnapshotLocation/@EntryValue">/home/schiemas/.cache/JetBrains/Rider2025.1/resharper-host/temp/Rider/vAny/CoverageData/_skyscraper8.1808907683/Snapshot/snapshot.utdcvr</s:String>
-	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=92c8346e_002D5416_002D4320_002Dab1d_002D051307b205cd/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" Name="All tests from &amp;lt;skyscraper8.Tests&amp;gt; #2" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;&#xD;
+	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=145b05c0_002D83b0_002D4386_002Db9fb_002De55ec3152557/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" IsActive="True" Name="All tests from &amp;lt;skyscraper8.Tests&amp;gt;" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;
-  &lt;Project Location="\home\schiemas\RiderProjects\skyscraper8\skyscraper8.Tests" Presentation="&amp;lt;skyscraper8.Tests&amp;gt;" /&gt;&#xD;
+  &lt;And&gt;
+    &lt;Namespace&gt;skyscraper8.Tests&lt;/Namespace&gt;
+    &lt;Project Location="/home/schiemas/RiderProjects/skyscraper8/skyscraper8.Tests" Presentation="&amp;lt;skyscraper8.Tests&amp;gt;" /&gt;
+  &lt;/And&gt;
 &lt;/SessionState&gt;</s:String>
-	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=94eea68c_002Dcaa0_002D4657_002Da521_002D7b96c8ead0ec/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" IsActive="True" Name="All tests from &amp;lt;skyscraper8.Tests&amp;gt;" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;&#xD;
+	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=58c56b00_002Df81e_002D48fd_002Da74f_002Dc8e84271fcf4/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" IsActive="True" Name="Continuous Testing" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;
-  &lt;Project Location="\home\schiemas\RiderProjects\skyscraper8\skyscraper8.Tests" Presentation="&amp;lt;skyscraper8.Tests&amp;gt;" /&gt;&#xD;
+  &lt;Project Location="/home/schiemas/RiderProjects/skyscraper8/skyscraper8.Tests" Presentation="&amp;lt;skyscraper8.Tests&amp;gt;" /&gt;
 &lt;/SessionState&gt;</s:String>
+	<s:String x:Key="/Default/Environment/UnitTesting/UnitTestSessionStore/Sessions/=ce70f33b_002D9024_002D4750_002Da24e_002D78f4e8e5e879/@EntryIndexedValue">&lt;SessionState ContinuousTestingMode="0" Name="All tests from &amp;lt;skyscraper8.Tests&amp;gt;" xmlns="urn:schemas-jetbrains-com:jetbrains-ut-session"&gt;
+  &lt;Project Location="/home/schiemas/RiderProjects/skyscraper8/skyscraper8.Tests" Presentation="&amp;lt;skyscraper8.Tests&amp;gt;" /&gt;
+&lt;/SessionState&gt;</s:String>
+	
+	
+	
+	
 	
 	
 	<s:String x:Key="/Default/Profiling/Configurations/=1/@EntryIndexedValue">&lt;data&gt;&lt;HostParameters type="LocalHostParameters" /&gt;&lt;Argument type="StandaloneArgument"&gt;&lt;Arguments IsNull="False"&gt;&lt;/Arguments&gt;&lt;FileName IsNull="False"&gt;&lt;/FileName&gt;&lt;WorkingDirectory IsNull="False"&gt;&lt;/WorkingDirectory&gt;&lt;Scope&gt;&lt;ProcessFilters /&gt;&lt;/Scope&gt;&lt;/Argument&gt;&lt;Info type="TimelineInfo" /&gt;&lt;CoreOptions type="CoreOptions"&gt;&lt;CoreTempPath IsNull="False"&gt;&lt;/CoreTempPath&gt;&lt;RemoteEndPoint IsNull="False"&gt;&lt;/RemoteEndPoint&gt;&lt;AdditionalEnvironmentVariables /&gt;&lt;/CoreOptions&gt;&lt;HostOptions type="HostOptions"&gt;&lt;HostTempPath IsNull="False"&gt;&lt;/HostTempPath&gt;&lt;/HostOptions&gt;&lt;/data&gt;</s:String>

skyscraper8/Docsis/DocsisEnvironment.cs

@@ -339,18 +339,7 @@ namespace skyscraper5.Docsis
                     break;
                 case nameof(PrivacyKeyManagementResponse):
                     PrivacyKeyManagementResponse privacyKeyManagementResponse = (PrivacyKeyManagementResponse)mmm;
-                    switch (privacyKeyManagementResponse.Code)
+                    eventHandler.OnKeyManagementResponse(privacyKeyManagementResponse);
-                    {
-                        case 5:
-                            //Contains a scrambled authentication key, so not interesting for us
-                            break;
-                        case 8:
-                            //Since the key is encrypted as well, this isn't interesting.
-                            break;
-                        default:
-                            //CM-SP-SECv4.0-I01-190815.pdf page 50
-                            throw new NotImplementedException(String.Format("{0}.{1} {2}", nameof(PrivacyKeyManagementResponse), nameof(privacyKeyManagementResponse.Code), privacyKeyManagementResponse.Code));
-                    }
                     break;
                 case nameof(DynamicServiceChangeResponse):
                     //Nothing of interesent in here either.
@@ -362,7 +351,8 @@ namespace skyscraper5.Docsis
                     //not interesting
                     break;
                 case nameof(DynamicServiceAdditionResponse):
-                    //not interesting
+                    DynamicServiceAdditionResponse dynamicServiceAdditionResponse = (DynamicServiceAdditionResponse)mmm;
+                    eventHandler.OnDynamicServiceAddition(dynamicServiceAdditionResponse.TransactionId, dynamicServiceAdditionResponse.ConfirmationCode, dynamicServiceAdditionResponse.TlvEncodedInformation);
                     break;
                 case nameof(DynamicServiceDeletionResponse):
                     //nothing in there

skyscraper8/Docsis/IDocsisEventHandler.cs

@@ -5,6 +5,7 @@ using System.Net;
 using System.Net.NetworkInformation;
 using System.Text;
 using System.Threading.Tasks;
+using skyscraper5.Docsis.AnnexC;
 using skyscraper5.Docsis.MacManagement;
 
 namespace skyscraper5.Docsis
@@ -16,5 +17,7 @@ namespace skyscraper5.Docsis
         void OnUpstreamChannel(UpstreamChannelDescriptor mmm);
         void OnDownstreamChannel(PhysicalAddress physicalAddress, MacDomainDescriptor.DownstreamActiveChannel downstreamActiveChannel);
         void OnLearnedIpFromMac(PhysicalAddress arpHeaderSenderHardwareAddress, IPAddress arpHeaderSenderProtocolAddress);
+        void OnKeyManagementResponse(PrivacyKeyManagementResponse privacyKeyManagementResponse);
+        void OnDynamicServiceAddition(ushort transactionId, byte confirmationCode, CommonTlvEncodingObject tlvEncodedInformation);
     }
 }

skyscraper8/Docsis/MacManagement/BaselinePrivacyKeyManagementMessages/5_AuthReply.cs

@@ -4,7 +4,7 @@ using System.IO;
 
 namespace skyscraper5.Docsis.MacManagement.BaselinePrivacyKeyManagementMessages
 {
-    internal class AuthReply : PrivacyKeyManagementResponse.BpkmMessageObject
+    public class AuthReply : PrivacyKeyManagementResponse.BpkmMessageObject
     {
         public AuthReply(byte[] buffer) : base(buffer)
         {
@@ -39,7 +39,7 @@ namespace skyscraper5.Docsis.MacManagement.BaselinePrivacyKeyManagementMessages
 		public byte[] AuthKey { get; private set; }
 		public SaDescriptorObject SaDescriptor { get; private set; }
 
-		internal class SaDescriptorObject
+		public class SaDescriptorObject
 		{
             public SaDescriptorObject(byte[] buffer)
             {
@@ -70,10 +70,10 @@ namespace skyscraper5.Docsis.MacManagement.BaselinePrivacyKeyManagementMessages
                 }
             }
 
-			public ushort SAID { get; }
+			public ushort SAID { get; private set; }
-			public SaTypeEnum SaType { get; }
+			public SaTypeEnum SaType { get; private set; }
-			public DataEncryptionAlgorithmIdentifiers DataEncryptionAlgorithm { get; }
+			public DataEncryptionAlgorithmIdentifiers DataEncryptionAlgorithm { get; private set; }
-			public DataAuthenticationIdentifiers DataAuthenticationAlgorithm { get; }
+			public DataAuthenticationIdentifiers DataAuthenticationAlgorithm { get; private set; }
 
 			public enum SaTypeEnum
             {

skyscraper8/Docsis/MacManagement/BaselinePrivacyKeyManagementMessages/8_KeyReply.cs

@@ -8,7 +8,7 @@ using skyscraper5.Skyscraper.IO;
 
 namespace skyscraper5.Docsis.MacManagement.BaselinePrivacyKeyManagementMessages
 {
-    internal class KeyReply : PrivacyKeyManagementResponse.BpkmMessageObject
+    public class KeyReply : PrivacyKeyManagementResponse.BpkmMessageObject
     {
         public KeyReply(byte[] buffer) : base(buffer)
         {

skyscraper8/Docsis/MacManagement/T13_V1_PrivacyKeyManagementResponse.cs

@@ -13,7 +13,7 @@ namespace skyscraper5.Docsis.MacManagement
 {
     [SkyscraperPlugin]
     [MacManagementMessageType(1,13)]
-    internal class PrivacyKeyManagementResponse : MacManagementMessage
+    public class PrivacyKeyManagementResponse : MacManagementMessage
     {
         public PrivacyKeyManagementResponse(PhysicalAddress source, PhysicalAddress destination, byte[] buffer) : base(source, destination, buffer)
         {
@@ -22,7 +22,11 @@ namespace skyscraper5.Docsis.MacManagement
             Identifier = ms.ReadUInt8();
             ushort length = ms.ReadUInt16BE();
             if (length > ms.GetAvailableBytes())
+            {
+                Valid = false;
                 return;
+            }
+
             byte[] subbuffer = ms.ReadBytes(length);
 
             switch (Code)
@@ -52,7 +56,7 @@ namespace skyscraper5.Docsis.MacManagement
             protected BpkmMessageObject(byte[] buffer)
             {
                 MemoryStream ms = new MemoryStream(buffer, false);
-                while (ms.GetAvailableBytes() > 3)
+                while (ms.GetAvailableBytes() >= 3)
                 {
                     byte type = ms.ReadUInt8();
                     ushort length = ms.ReadUInt16BE();

skyscraper8/Docsis/MacManagement/T5_V1_RangingResponse.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.IO;
 using System.Linq;
 using System.Net.NetworkInformation;
@@ -36,7 +37,7 @@ namespace skyscraper5.Docsis.MacManagement
                     Valid = false;
                     return;
                 }
-                if (length == 0)
+                if (length == 0 && type != 15 && type != 16)
                 {
                     Valid = false;
                     return;
@@ -99,8 +100,7 @@ namespace skyscraper5.Docsis.MacManagement
                         SCdmaPowerHeadroom = v[0];
                         break;
                     case 12:
-						byte[] upstreamChannelAdjustmentsBuffer = ms.ReadBytes(length);
+                        UpstreamChannelAdjustments = new UpstreamChannelAdjustmentsObject(v);
-                        UpstreamChannelAdjustments = new UpstreamChannelAdjustmentsObject(upstreamChannelAdjustmentsBuffer);
                         break;
                     case 13:
                         T4TimeoutMultiplier = v[0];
@@ -118,13 +118,13 @@ namespace skyscraper5.Docsis.MacManagement
                             newLen = (ushort)ms.GetAvailableBytes();
                         }
 						v = ms.ReadBytes(newLen);
-						TransmitEqualizationEncodingsForOfdmaChannels result1516 = Parse1516(v);
                         if (type == 15)
                             TransmitEqualizationAdjustForOfdmaChannels = Parse1516(v);
-                        else if (type == 16)
-                            TransmitEqualizationSetForOfdmaChannels = Parse1516(v);
                         else
-                            throw new NotImplementedException(String.Format("2-byte TLV entry in Ranging Response with ID {0}", type));
+                        {
+                            Debug.Assert(type == 16);
+                            TransmitEqualizationSetForOfdmaChannels = Parse1516(v);
+                        }
                         break;
 					case 17:
                         CommandPower = new CommandPowerObject(v);
@@ -145,11 +145,6 @@ namespace skyscraper5.Docsis.MacManagement
 						}
 						break;
 					default:
-                        if (type > 18)
-                        {
-                            Valid = false;
-                            return;
-                        }
                         //see CM-SP-MULPIv4.0-I01-190815.pdf page 141
                         throw new NotImplementedException(String.Format("{0} Type {1}", nameof(RangingResponse), type));
                 }
@@ -184,8 +179,8 @@ namespace skyscraper5.Docsis.MacManagement
 		}
 
         public TransmitEqualizationEncodingsForOfdmaChannels TransmitEqualizationAdjustForOfdmaChannels { get; private set; }
-        private CommandPowerObject CommandPower { get; set; }
+        public CommandPowerObject CommandPower { get; set; }
-        class CommandPowerObject : Validatable
+        public class CommandPowerObject : Validatable
         {
             public CommandPowerObject(byte[] buffer)
             {
@@ -255,7 +250,7 @@ namespace skyscraper5.Docsis.MacManagement
 		public byte? UpstreamChannelIdOverride { get; private set; }
 		public byte? SCdmaPowerHeadroom { get; }
 		public UpstreamChannelAdjustmentsObject UpstreamChannelAdjustments { get; private set; }
-		private CommandPowerObject FdxCommandedPower { get; }
+		public CommandPowerObject FdxCommandedPower { get; }
 		public byte? TimingAdjustFractionalPart { get; }
 		public byte? SCdmaMaximumScheduledCodes { get; }
 

skyscraper8/Docsis/NullDocsisEventHandler.cs

@@ -1,33 +1,85 @@
 using System.Net;
 using System.Net.NetworkInformation;
+using skyscraper5.Docsis.AnnexC;
 using skyscraper5.Docsis.MacManagement;
 
 namespace skyscraper5.Docsis;
 
 public class NullDocsisEventHandler : IDocsisEventHandler
 {
+    private HashSet<PhysicalAddress> participants;
+    private uint? timing;
+    private Dictionary<PhysicalAddress, IPAddress> knownIps;
+    
     public void OnParticipantDetected(PhysicalAddress pa)
     {
-        throw new NotImplementedException();
+        if (participants == null)
+            participants = new HashSet<PhysicalAddress>();
+
+        participants.Add(pa);
     }
 
     public void OnCmtsTimestamp(PhysicalAddress source, uint timing)
     {
-        throw new NotImplementedException();
+        OnParticipantDetected(source);
+        this.timing = timing;
     }
 
     public void OnUpstreamChannel(UpstreamChannelDescriptor mmm)
     {
-        throw new NotImplementedException();
+        if (_queue == null)
+            _queue = new Queue<object>();
+        
+        _queue.Enqueue(mmm);
     }
 
     public void OnDownstreamChannel(PhysicalAddress physicalAddress, MacDomainDescriptor.DownstreamActiveChannel downstreamActiveChannel)
     {
-        throw new NotImplementedException();
+        if (_queue == null)
+            _queue = new Queue<object>();
+        
+        _queue.Enqueue(downstreamActiveChannel);
     }
 
     public void OnLearnedIpFromMac(PhysicalAddress arpHeaderSenderHardwareAddress, IPAddress arpHeaderSenderProtocolAddress)
     {
-        throw new NotImplementedException();
+        if (knownIps == null)
+            knownIps = new Dictionary<PhysicalAddress, IPAddress>();
+        
+        knownIps.Add(arpHeaderSenderHardwareAddress, arpHeaderSenderProtocolAddress);
+    }
+
+    public void OnKeyManagementResponse(PrivacyKeyManagementResponse privacyKeyManagementResponse)
+    {
+        if (_queue == null)
+            _queue = new Queue<object>();
+        
+        _queue.Enqueue(privacyKeyManagementResponse);
+    }
+
+    public void OnDynamicServiceAddition(ushort transactionId, byte confirmationCode,
+        CommonTlvEncodingObject tlvEncodedInformation)
+    {
+        if (_queue == null)
+            _queue = new Queue<object>();
+        
+        _queue.Enqueue(tlvEncodedInformation);
+    }
+
+    private Queue<object> _queue;
+
+    public Queue<object> GetQueue()
+    {
+        return _queue;
+    }
+
+    public HashSet<PhysicalAddress> GetParticipants()
+    {
+        return participants;
+    }
+
+    public uint GetTiming()
+    {
+        return timing.Value;
     }
 }

skyscraper8/Experimentals/NdsSsu/NdsSsuDetector.cs

@@ -106,7 +106,7 @@ namespace skyscraper8.Experimentals.NdsSsu
 
 		public void OnNdsSsuError(int pid, NdsSsuError error)
 		{
-			throw new NotImplementedException();
+			Score--;
 		}
 
 		private int maxNumFiles;

skyscraper8/Skyscraper/Scraper/SkyscraperContext.cs

@@ -97,6 +97,7 @@ using Platform = skyscraper5.Dvb.SystemSoftwareUpdate.Model.Platform;
 using RntParser = skyscraper5.Dvb.TvAnytime.RntParser;
 using skyscraper8.DvbSis;
 using skyscraper8.T2MI.Packets;
+using skyscraper5.Docsis.AnnexC;
 
 namespace skyscraper5.Skyscraper.Scraper
 {
@@ -3313,6 +3314,16 @@ namespace skyscraper5.Skyscraper.Scraper
         void T2MIEventHandler.OnFramingAndTimingInformation(int relatedPid, _0xF0_FramingTimingInformation fti)
         {
             logger.WarnFormat("Found T2MI F&TI Information on PID 0x{0:X4}. This isn't supported yet. It would be great if you could share a sample of this stream, so this can be implemented.", relatedPid);
-        }
+        }
+
+        public void OnKeyManagementResponse(PrivacyKeyManagementResponse privacyKeyManagementResponse)
+        {
+            logger.WarnFormat("Found a DOCSIS Key Management Response. Those aren't supported yet. It would be great if you could share a sample of this stream, so those can be implemented.");
+        }
+
+        public void OnDynamicServiceAddition(ushort transactionId, byte confirmationCode, CommonTlvEncodingObject tlvEncodedInformation)
+        {
+            logger.WarnFormat("Found a DOCSIS Dynamic Service Addition. Those aren't supported yet. It would be great if you could share a sample of this stream, so those can be implemented.");
+        }
     }
 }